async_hooks: improve resource stack performance#33575
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
async_hooks: improve resource stack performance#33575addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes some of the performance overhead that came with
executionAsyncResource()by storing async resources thatare managed by JS and those managed by C++ separately, and
instead caching the result of
executionAsyncResource()withlow overhead to avoid multiple calls into C++.
This particularly improves performance when async hooks are not
being used.
(I’ll also try to run the
async_hooksbenchmarks, but they are failing locally for me on master – hence only the ones for MessagePorts as another measure.)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes